ci: enable strict golangci-lint#781
Closed
cssbruno wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing because the head branch used the old codex/* naming pattern. Reopening from ci/strict-golangci-lint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lintv2.12.2 configuration, pinned local runner, and GitHub Actions lint workflow.Issue Closure
Related: lint gate hardening; no issue auto-close.
Verification
scripts/test-go-modules.shwhen Go code or compiler behavior changed.go build ./cmd/gowdkwhen CLI, compiler, runtime, addon, or release behavior changed.node --check editors/vscode/extension.jswhen editor files changed.Commands run:
scripts/check-golangci-lint.sh->0 issues.go test ./internal/publicapi -count=1go test ./internal/gowdkcmd -run 'TestBuildCommandProductionScansFinalArtifactsForSecrets|TestBuildCommandProductionBlocksInsecureAuditFindings|TestComputeAuditDiffClassifiesIntroducedResolvedUnchanged' -count=1go build ./cmd/gowdkgit diff --checkKnown gap: full
go test ./...was attempted earlier, but the existing nestedinternal/gowdkcmdintegration tests ran excessively long. This PR is validated with the lint gate and focused tests for the touched late fixes.LLM Assistance
main, resolved conflicts, and opened this draft PR.internal/gowdkcmdintegration tests can complete.